Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows quoted default values #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

barbagus
Copy link

As mentioned in #46 there is a use cases for quoting default value (when having spaces in the default value). This PR allows such single/double quoted default value.

For your consideration.

If a default value is (single or double) quoted, the quotes will be removed from the actual value.
This allows for clearer default value containing spaces:
```
--name-sep=<sep>  name field separator [default: " - "] 
```
Fixes quoted default value for single characters
@NickCrews
Copy link
Contributor

Thanks for your effort here!

See #46:

  • please comment on my suggested test cases there
  • once we decide desired behavior, implement those test cases here
  • also, please extract this logic into its own little self-contained helper function

Once you do this, I can accept this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants